Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new methods signRequest and signResponse #33

Open
aljones15 opened this issue Jan 2, 2021 · 0 comments
Open

Create new methods signRequest and signResponse #33

aljones15 opened this issue Jan 2, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@aljones15
Copy link
Contributor

aljones15 commented Jan 2, 2021

Currently in order to sign a request 2 different functions are called:

createAuthzHeader

createSignatureString

I think we should create a new function: signRequest and signResponse that uses these 2 functions, and a derefernced key to sign the request or response.

This would also allow us to do more validation when signing while knowing the algorithm and keyType.

While not as dire, verifyRequest and verifyResponse might be similarly useful and could wrap around parseRequest.

@aljones15 aljones15 self-assigned this Jan 2, 2021
@aljones15 aljones15 added the enhancement New feature or request label Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant