Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGAPP-109: Use url to get pathnames instead of workaround #1080

Closed
jira-to-github-migrator bot opened this issue Aug 12, 2023 · 0 comments
Closed

IGAPP-109: Use url to get pathnames instead of workaround #1080

jira-to-github-migrator bot opened this issue Aug 12, 2023 · 0 comments
Assignees
@sarahsporck
Labels
good first issue Good for newcomers Native Affects the native project ready Task

Comments

@jira-to-github-migrator
Copy link

steffenkleinle - 8.5.2019, 13:34:21

Update: https://github.com/charpeni/react-native-url-polyfill is available as stated in the linked github issue.

 

See facebook/react-native#16434 . Using URL currently throws an exception and does not work.

Therefore, currently we split the url manually (in createNavigateToInternalLink: https://github.com/Integreat/integreat-app/blob/00801819fcba7b0cec3903ebfbe3cd28644b8002/native/src/modules/app/createNavigateToInternalLink.js#L25).

Use the url prolyfill for this. It is already used in other parts of the app.

Environment: -
Linked issues:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahsporck sarahsporck

Labels
good first issue Good for newcomers Native Affects the native project ready Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sarahsporck