Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGAPP-1241: Send app language to OS for screen reader #2173

Open
jira-to-github-migrator bot opened this issue Aug 12, 2023 · 4 comments · May be fixed by #2910
Open

IGAPP-1241: Send app language to OS for screen reader #2173

jira-to-github-migrator bot opened this issue Aug 12, 2023 · 4 comments · May be fixed by #2910
Assignees
@LeandraH
Labels
A11y Accessibility iOS only concerns ios devices ready Task

Comments

@jira-to-github-migrator
Copy link

jira-to-github-migrator bot commented Aug 12, 2023 •
edited by steffenkleinle
Loading

The Screen reader needs to know the language of the current app. If you change the language, screen reader needs to know how to pronounce the new language. For that the app can send the current language to the OS.

This only needs to be done for iOS as it is already working decently for Android.
For ios there is a RN prop that can be set: https://reactnative.dev/docs/accessibility#accessibilitylanguage-ios
@jira-to-github-migrator jira-to-github-migrator bot added accessibility Native Affects the native project Task labels Aug 12, 2023
@jira-to-github-migrator jira-to-github-migrator bot added this to the Accessibility milestone Aug 12, 2023
@ztefanie
Copy link
Member

ztefanie commented Nov 9, 2023

For ios there is a RN prop that can be set: https://reactnative.dev/docs/accessibility#accessibilitylanguage-ios

@steffenkleinle steffenkleinle added the A11y Accessibility label Jun 10, 2024
@steffenkleinle steffenkleinle removed this from the Accessibility milestone Jun 10, 2024
@LeandraH LeandraH self-assigned this Jun 17, 2024
@LeandraH
Copy link
Contributor

I haven't found a way to get this running in Android. Michi apparently raised this point quite a while ago but it didn't really lead anywhere (react-native-community/discussions-and-proposals#212). We'll have to discuss next steps in our weekly meeting next week.

@LeandraH LeandraH assigned ztefanie and unassigned LeandraH Jul 1, 2024
@LeandraH
Copy link
Contributor

LeandraH commented Jul 1, 2024

@ztefanie agreed to do some more research into getting this working for Android.

@ztefanie ztefanie removed the good first issue Good for newcomers label Jul 15, 2024
@ztefanie
Copy link
Member

ztefanie commented Aug 19, 2024 •
edited
Loading

I just enabled TalkBack on my real device and tested integreat. It reads out everything in the correct language, latest version of TalkBack is smart enough to know which language a text is and change on the fly. Both content text and app constants are read out correctly.

Only thing I found that is not read out in the correct language is the language in the language menu. e.g. wjhen system language is german and i click on "english" in the language menu it is read out in german and not in english. But everything beside this is already working fine in android.

@steffenkleinle steffenkleinle added iOS only concerns ios devices and removed Native Affects the native project labels Aug 19, 2024
@LeandraH LeandraH self-assigned this Sep 2, 2024
@LeandraH LeandraH linked a pull request Sep 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeandraH LeandraH

Labels
A11y Accessibility iOS only concerns ios devices ready Task
Projects
team-app
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2173: Send language to iOS VoiceOver digitalfabrik/integreat-app
4 participants
@ztefanie @LeandraH @sarahsporck @steffenkleinle