Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for embedded offers/malte help offer #2642

Open
2 tasks
sarahsporck opened this issue Jan 22, 2024 · 1 comment · May be fixed by #2979
Open
2 tasks

Add tests for embedded offers/malte help offer #2642

sarahsporck opened this issue Jan 22, 2024 · 1 comment · May be fixed by #2979
Assignees
@LeandraH
Labels
Native Affects the native project not-testable Not testable by our tester ready shared Affects the shared project Test Web Affects the web project

Comments

@sarahsporck
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We are making an effort to increase our test coverage and stability, therefore we want to enforce a good practice and always write tests, when implementing a new feature ❤️ .
Due to time pressure we weren't really able to add tests for these components. Let's add them once we are finished.

Describe the solution you'd like
Add tests for

  • embedded offers
  • malte help offer

Describe alternatives you've considered
Don't add tests.

Additional context
https://codeclimate.com/github/digitalfabrik/integreat-app/code?q=embedded
https://codeclimate.com/github/digitalfabrik/integreat-app/code?q=MalteHelp
@sarahsporck sarahsporck added Test Web Affects the web project Native Affects the native project shared Affects the shared project labels Jan 22, 2024
@LeandraH LeandraH added ready not-testable Not testable by our tester labels Jan 24, 2024
@LeandraH LeandraH self-assigned this May 23, 2024
@steffenkleinle
Copy link
Member

@LeandraH just a short heads up: A lot of offers stuff is removed (and a little refactored) in #2467. So perhaps it makes sense to wait with this for a little while still.

@LeandraH LeandraH removed their assignment Jun 17, 2024
@LeandraH LeandraH self-assigned this Oct 15, 2024
@LeandraH LeandraH linked a pull request Oct 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeandraH LeandraH

Labels
Native Affects the native project not-testable Not testable by our tester ready shared Affects the shared project Test Web Affects the web project
Projects
team-app
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2642: Tests for EmbeddedOffers and MalteHelpForm digitalfabrik/integreat-app
3 participants
@LeandraH @sarahsporck @steffenkleinle