Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why install craco as dependencies but not devDependencies? #76

Closed
zhaoyao91 opened this issue Mar 13, 2019 · 6 comments
Closed

Why install craco as dependencies but not devDependencies? #76

zhaoyao91 opened this issue Mar 13, 2019 · 6 comments

Comments

@zhaoyao91
Copy link

Why install craco as dependencies but not devDependencies?

@patricklafrance
Copy link
Contributor

@ndbroadbent can you answer this one?

@zhaoyao91
Copy link
Author

I tried to install it as devDependence. By now I didn't find any problem.

@patricklafrance
Copy link
Contributor

@zhaoyao91 same here. The documentation have been updated to install craco as dependencies after a comment made by @ndbroadbent but I dont remember the specific reason.

@ndbroadbent
Copy link
Contributor

Here is the previous discussion: #23

This was important for when you are deploying to Heroku, or building a Docker image, because craco is required during a production build (same as react-scripts.) Check out some of the issues that I linked for the facebook/create-react-app repo where people also talk about this issue.

So I thought it would be good to match the behavior of react-scripts and also put craco in the dependencies section. But it's totally up to you, and devDependencies is also fine if it works for you.

@patricklafrance
Copy link
Contributor

Thank you @ndbroadbent

@takhello
Copy link

takhello commented Jan 7, 2020

It seems that react is not very sound, not very willing to use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants