Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bevy v0.4.0 #45

Merged
merged 3 commits into from
Dec 21, 2020
Merged

Update to bevy v0.4.0 #45

merged 3 commits into from
Dec 21, 2020

Conversation

Fedcomp
Copy link
Contributor

@Fedcomp Fedcomp commented Dec 20, 2020

Tests pass (my linux), it compiles (my linux). Not sure if this PR is usefull for anyone.

Big thanks to @alec-deason ( #30 ) it was really usefull reference while i was updating bevy_rapier and i saved a lot of my time thanks to it.

@sebcrozet
Copy link
Member

Hi! Thank you for this PR. How does this differ from #30 exactly?

@Fedcomp
Copy link
Contributor Author

Fedcomp commented Dec 20, 2020

@sebcrozet mine targets stable bevy 0.4.0 (unlike the #30 ) and i am in the process of fixing examples (which is also not fixed in that PR).
For example boxes3 example has 2x smaller boxes than their invisible colliding boxes and physics simulation speed text is simply not updating from default text (something with font rendering changes i guess, it works if i move text update system to update stage).

I am going to make this completely ready to be merged with all examples working and all issues fixed (even if i have to open issues in the bevy itself).

I see no problem if you update bevy_rapier on your own. I had to update it to get new version faster for my own game, and decided to share my work and make it completely mergeable with zero issues.

@Fedcomp
Copy link
Contributor Author

Fedcomp commented Dec 20, 2020

apparently size of Mesh::from(shape::Cube { size: 1.0 }) is 2x smaller now.

@Fedcomp
Copy link
Contributor Author

Fedcomp commented Dec 20, 2020

And POST_UPDATE for debug ui text is no longer an option: bevyengine/bevy#1102 (comment)

@Fedcomp
Copy link
Contributor Author

Fedcomp commented Dec 20, 2020

Mesh::from(shape::Cube { size: 2.0 }) go brrr

@Fedcomp
Copy link
Contributor Author

Fedcomp commented Dec 21, 2020

I've moved bevy ui diagnostics plugin to UPDATE stage instead of POST_UPDATE due to issue with perfomant fonts in bevy 0.4.0.

@Fedcomp Fedcomp marked this pull request as ready for review December 21, 2020 00:18
@Fedcomp
Copy link
Contributor Author

Fedcomp commented Dec 21, 2020

Examples visually looks the same as in bevy_rapier for bevy 0.3.0 (i did side by side comparison). But simulation feels like x2 faster.
@sebcrozet it would be cool to get PR review from you, it's probably ready to be merged.

@sebcrozet sebcrozet merged commit 54e44f3 into dimforge:master Dec 21, 2020
@sebcrozet
Copy link
Member

Seems all good. Thanks!

@sebcrozet
Copy link
Member

And thanks to @alec-deason for their initial work on this with #30!

@sebcrozet
Copy link
Member

I made a release of bevy_rapier 0.7 which includes these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants