feat: add included option #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/resolvers/md2md.ts
Outdated
| writeFileSync(targetDestPath, result); | ||
| return result; |
There was a problem hiding this comment.
wouldn't it be better to read the file separately, not as side effect of the copyFile function ?
for both cases it would be readFileSync(targetDestPath, 'utf8');
There was a problem hiding this comment.
Fixed in diplodoc-platform/transform#509
makamekm
force-pushed
the
add-included-option
branch
from
fb91550 to
7c090ff
Compare
martyanovandrey
approved these changes
Sep 17, 2024
makamekm
force-pushed
the
add-included-option
branch
from
66bd83f to
b38a716
Compare
martyanovandrey
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.