Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html5 script tags and no-comment-replace options? #18

Open
peterchappell opened this issue Oct 4, 2011 · 2 comments
Open

html5 script tags and no-comment-replace options? #18

peterchappell opened this issue Oct 4, 2011 · 2 comments

Comments

@peterchappell
Copy link

Hi,

I really like the simplicity of press - thanks for your work on it.

I don't know if you're still actively working on the module but if you are, do you think you could allow for a html5 option for the script tag. It would render a script tag like this:

<script src="/press/js/hash.js"></script>

Also it would be great if you could allow an option not to replace the individual script elements with a corresponding comment.

Thanks again.

Pete.

@dirkmc
Copy link
Owner

dirkmc commented Oct 4, 2011

Hi Peter,
I'm not sure what you mean, the script tags should already be rendered like that. Could you explain the difference?

Unfortunately it's necessary to output the comments because press goes through the html after it has been generated in order to determine the order in which scripts should be added to the compressed file. It's not possible to do this at render time, only after rendering has finished.

@peterchappell
Copy link
Author

Hi,

Thanks for explaining about the comments. I understand.

The script tag isn't a big deal - just thought I'd ask.

In HTML5 you don't need the language, type or charset attributes on the script tag. Like I say, not a big deal, just thought that since you had a html/xhtml option you might like to include a html5 one as well.

Thanks again for all your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants