Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GuildChannel#guildId not being patched to undefined #10505

Merged
merged 2 commits into from
Sep 14, 2024
Merged

fix: GuildChannel#guildId not being patched to undefined #10505

merged 2 commits into from
Sep 14, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Sep 14, 2024

Please describe the changes this PR makes and why it should be merged:

Fixes #10495.

guild_id only gets passed to Action#getChannel() if it exists in the payload as key.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Qjuh Qjuh requested a review from a team as a code owner September 14, 2024 10:25
@vercel Vercel
Copy link

vercel bot commented Sep 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2024 10:55am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2024 10:55am

@Qjuh Qjuh requested a review from vladfrangu September 14, 2024 10:55
@vladfrangu vladfrangu added this to the discord.js 14.16.3 milestone Sep 14, 2024
@Qjuh Qjuh requested a review from Syjalo September 14, 2024 10:59
@kodiakhq kodiakhq bot merged commit 2adee06 into discordjs:main Sep 14, 2024
7 checks passed
@Qjuh Qjuh deleted the fix/guildchannel-null-guildid branch September 14, 2024 17:44
monbrey pushed a commit to monbrey/discord.js that referenced this pull request Sep 18, 2024
@Qjuh @monbrey
fix: GuildChannel#guildId not being patched to undefined (discord…
81b4996 
…js#10505)

* fix: `GuildChannel#guildId` not being patched to `undefined`

* fix: guildId to guild_id check
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
@Qjuh @nyapat
fix: GuildChannel#guildId not being patched to undefined (discord…
dd0aaf3 
…js#10505)

* fix: `GuildChannel#guildId` not being patched to `undefined`

* fix: guildId to guild_id check
@NotYourAverageGamer NotYourAverageGamer mentioned this pull request Oct 21, 2024
Merged
@mezotv mezotv mentioned this pull request Oct 23, 2024
Closed
@jshuntley jshuntley mentioned this pull request Oct 24, 2024
Open
@VicDario VicDario mentioned this pull request Oct 25, 2024
Merged
@HowlingArcher HowlingArcher mentioned this pull request Oct 25, 2024
Open
@lkeff lkeff mentioned this pull request Oct 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Oct 27, 2024
Open
@JajoScript JajoScript mentioned this pull request Oct 27, 2024
Merged
@whizbangpop whizbangpop mentioned this pull request Oct 27, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Oct 28, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Nov 1, 2024
Open
@saiteja-madha saiteja-madha mentioned this pull request Nov 2, 2024
Closed
@AlexEKinney AlexEKinney mentioned this pull request Nov 3, 2024
Open
@Adidi1234 Adidi1234 mentioned this pull request Nov 3, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Nov 3, 2024
Open
@Azzraya Azzraya mentioned this pull request Nov 5, 2024
Open
@ClearlyElevated ClearlyElevated mentioned this pull request Nov 6, 2024
Open
@jakejack13 jakejack13 mentioned this pull request Nov 7, 2024
Merged
@Genio40921 Genio40921 mentioned this pull request Nov 10, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Nov 10, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Nov 10, 2024
Open
@Azzraya Azzraya mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didinele didinele didinele approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@Syjalo Syjalo Awaiting requested review from Syjalo

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 14.16.3
Development

Successfully merging this pull request may close these issues.

interaction.channel.guildId undefined after ephemeral reply
5 participants
@Qjuh @vladfrangu @SpaceEEC @didinele @Syjalo