From aff5b3de94ca9fdd7bace26ec57c19aca9e4af28 Mon Sep 17 00:00:00 2001 From: Jiralite <33201955+Jiralite@users.noreply.github.com> Date: Mon, 10 Jul 2023 23:11:32 +0100 Subject: [PATCH] fix(ChannelUpdate): check against unknown channels --- .../discord.js/src/client/actions/ChannelUpdate.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/packages/discord.js/src/client/actions/ChannelUpdate.js b/packages/discord.js/src/client/actions/ChannelUpdate.js index 6b432c08bfb9..7ca331aacae9 100644 --- a/packages/discord.js/src/client/actions/ChannelUpdate.js +++ b/packages/discord.js/src/client/actions/ChannelUpdate.js @@ -6,14 +6,23 @@ const { createChannel } = require('../../util/Channels'); class ChannelUpdateAction extends Action { handle(data) { const client = this.client; - let channel = client.channels.cache.get(data.id); + if (channel) { const old = channel._update(data); if (channel.type !== data.type) { const newChannel = createChannel(this.client, data, channel.guild); - for (const [id, message] of channel.messages.cache) newChannel.messages.cache.set(id, message); + + if (!newChannel) { + this.client.channels.cache.delete(channel.id); + return {}; + } + + if (channel.isTextBased() && newChannel.isTextBased()) { + for (const [id, message] of channel.messages.cache) newChannel.messages.cache.set(id, message); + } + channel = newChannel; this.client.channels.cache.set(channel.id, channel); }