coroc: make callgraph construction algorithm configurable #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
x/tools/go/callgraph
package has four algorithms for constructing callgraphs. We're currently hard-coded to use VTA.This PR makes the algorithm configurable when using
coroc
, via a new-callgraph {static|cha|vta|rta}
option. Thecallgraph
tool (source) was helpful in determining how to use the construction algorithms.I've also added a
-colors
flag that enables debug output of the function coloring pass. It shows the roots (thecoroutine.Yield
functions, along with their type/color), and all edges that are followed in the coloring pass. It can be used to debug cases where a callgraph algorithm misses an edge, or where a function has more than one color.