Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review use of Pdeathsig #68

Closed
chriso opened this issue Jun 3, 2024 · 0 comments · Fixed by #75
Closed

Review use of Pdeathsig #68

chriso opened this issue Jun 3, 2024 · 0 comments · Fixed by #75
Assignees
@chriso

Comments

@chriso
Copy link
Contributor

chriso commented Jun 3, 2024

We may be using Pdeathsig incorrectly on Linux. The death signal is sent when the parent thread dies, not the process, which means it may be necessary to lock the goroutine to an OS thread while the child process is running.

See golang/go#27505
@chriso chriso mentioned this issue Jun 10, 2024
Merged
@chriso chriso self-assigned this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chriso chriso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

run: fix signal handling dispatchrun/dispatch
1 participant
@chriso