Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'onSuccess' parameter is not working on slack processor #779

Closed
educlos opened this issue Jun 5, 2020 · 1 comment
Closed

'onSuccess' parameter is not working on slack processor #779

educlos opened this issue Jun 5, 2020 · 1 comment

Comments

@educlos
Copy link
Contributor

educlos commented Jun 5, 2020

Describe the bug
When assigning the slack processor to a job, it will send a slack message on both success and failure regardless of the onSuccess parameter (I tested with it absent, set to false, or "false")

To Reproduce

  • Define the slack team on the dkron servers
  • Add the following on the job definition:
  "processors": {
    "slack": {
      "team": "slack",
      "channel": "#bot-testing"
    }
  },
  • Run the job

Expected behavior
A message is sent on slack only on failure, as defined on the documentation

Specifications:

  • OS: ubuntu (18 for the servers, 16 for the agents)
  • Version 3.0.0 (pro)
  • 3 nodes as server, few as agents
@educlos
Copy link
Contributor Author

educlos commented Jun 12, 2020

This issue got fixed in dkron-pro v3.0.1

@educlos educlos closed this as completed Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant