Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import project: Support repository URLs with .git or / suffix #368

Closed
viennem opened this issue Aug 18, 2023 · 0 comments · Fixed by #378
Closed

Import project: Support repository URLs with .git or / suffix #368

viennem opened this issue Aug 18, 2023 · 0 comments · Fixed by #378
Assignees
Labels
Bug Something isn't working

Comments

@viennem
Copy link
Member

viennem commented Aug 18, 2023

Describe the bug

When importing a project, the repository URL should support URLs with .git or / at the end.

This issue applies to both "Import new project" and "Create a project from a template" dialogs.

Currently:

  • .git suffix is not accepted by the validation rule:

    It should be accepted, because many users are used to copy/paste the URL from GitHub's "Code" button.

  • / suffix is accepted by the validation rule, but the project name extracted from the URL is empty, and it causes an error 404 after importing the project.

    The router redirected me to this URL: http://localhost:8080/projects//models.

Application

  • leto-modelizer commit hash: f59e63e9d861fb5d0f0849dc7983be3a76bd779a.
@viennem viennem added the Bug Something isn't working label Aug 18, 2023
@viennem viennem moved this to 🔖 Ready in Board of Leto-modelizer Aug 18, 2023
@Zorin95670 Zorin95670 moved this from 🔖 Ready to 🏗 In progress in Board of Leto-modelizer Aug 21, 2023
@Zorin95670 Zorin95670 self-assigned this Aug 21, 2023
@Zorin95670 Zorin95670 added this to the Release version 1.3.0 milestone Aug 21, 2023
@Zorin95670 Zorin95670 moved this from 🏗 In progress to 👀 In review in Board of Leto-modelizer Aug 21, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Board of Leto-modelizer Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants