Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add match expressions #22

Merged
merged 7 commits into from
Apr 19, 2022
Merged

Add match expressions #22

merged 7 commits into from
Apr 19, 2022

Conversation

jmackie
Copy link
Member

@jmackie jmackie commented Apr 6, 2022 •
edited
Loading

  • Parse the new expression type in ditto-cst
  • Add the new expression type to ditto-ast
  • Type check the new expression type in ditto-checker
  • Extend the JavaScript code generator
  • Extend the expression formatting logic in ditto-fmt

@jmackie jmackie linked an issue Apr 6, 2022 that may be closed by this pull request
Add match expressions #4
Closed
3 tasks
@jmackie jmackie marked this pull request as ready for review April 19, 2022 09:33
@jmackie jmackie mentioned this pull request Apr 19, 2022
Closed
3 tasks
@jmackie jmackie merged commit c06983b into main Apr 19, 2022
@jmackie jmackie deleted the add-match-expressions branch April 19, 2022 09:44
jmackie
jmackie commented Apr 19, 2022
View reviewed changes
crates/ditto-codegen-js/src/convert.rs
arguments: _,
..
} => {
todo!();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@jmackie jmackie changed the title Add match expressions to the CST Add match expressions Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add match expressions
1 participant
@jmackie