Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the pipe operator |> #41

Merged
merged 4 commits into from
Apr 24, 2022
Merged

Add the pipe operator |> #41

merged 4 commits into from
Apr 24, 2022

Conversation

jmackie
Copy link
Member

@jmackie jmackie commented Apr 23, 2022

  • Add parsing logic for binary operators (initially just the |> operator) to ditto-cst
  • Desugar pipes as part of the "pre-AST" generation in ditto-checker
  • Extend the expression formatting logic in ditto-fmt
  • Ensure the generated JavaScript is as expected

@jmackie jmackie linked an issue Apr 23, 2022 that may be closed by this pull request
2 tasks
@jmackie jmackie mentioned this pull request Apr 23, 2022
2 tasks
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #41 (d2a2f3d) into main (b2b1256) will increase coverage by 0.16%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   77.59%   77.76%   +0.16%     
==========================================
  Files         108      109       +1     
  Lines        6674     6742      +68     
==========================================
+ Hits         5179     5243      +64     
- Misses       1495     1499       +4     
Impacted Files Coverage Δ
crates/ditto-cst/src/parser/token.rs 94.59% <ø> (ø)
crates/ditto-cst/src/token.rs 92.85% <ø> (ø)
crates/ditto-fmt/src/has_comments.rs 45.67% <14.28%> (-1.10%) ⬇️
...ditto-checker/src/module/value_declarations/mod.rs 99.19% <100.00%> (+<0.01%) ⬆️
crates/ditto-checker/src/typechecker/pre_ast.rs 96.66% <100.00%> (+0.30%) ⬆️
.../ditto-checker/src/typechecker/tests/right_pipe.rs 100.00% <100.00%> (ø)
crates/ditto-cst/src/get_span.rs 94.36% <100.00%> (+0.08%) ⬆️
crates/ditto-cst/src/parser/expression.rs 100.00% <100.00%> (ø)
crates/ditto-fmt/src/expression.rs 99.61% <100.00%> (+0.02%) ⬆️
crates/ditto-fmt/src/token.rs 97.89% <100.00%> (+0.02%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b1256...d2a2f3d. Read the comment docs.

@jmackie jmackie self-assigned this Apr 24, 2022
@jmackie jmackie merged commit c9707c8 into main Apr 24, 2022
@jmackie jmackie deleted the add-pipe-operator branch April 24, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the pipe operator |>
1 participant