Drop our snapshot-test crate for datatest-stable 🗑️
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 81.32% 80.89% -0.43%
==========================================
Files 82 80 -2
Lines 14611 14258 -353
==========================================
- Hits 11882 11534 -348
+ Misses 2729 2724 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jmackie
force-pushed
the
rm-snapshot-test
branch
from
2ef2ad9
to
056d465
Compare
jmackie
force-pushed
the
rm-snapshot-test
branch
from
056d465
to
06c50ff
Compare
jmackie
force-pushed
the
main
branch
4 times, most recently
from
9466d3f
to
fecc716
Compare
jmackie
force-pushed
the
rm-snapshot-test
branch
from
06c50ff
to
6860bc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snapshot-testwas a quick and dirty replacement for `datatest, which was broken for recent nightly compilers.But
datatest-stableis much better, so let's use that instead. 👌As part of this, I also moved golden test files to live under the
testsdirectory.