From 8ca2ad8c37b030f4538e9aa463ef52a5d9ff2e42 Mon Sep 17 00:00:00 2001 From: David Cook Date: Fri, 15 Sep 2023 15:09:24 -0500 Subject: [PATCH 1/2] Remove extra console.log() statement in test --- packages/dap/src/hpkeConfig.spec.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/dap/src/hpkeConfig.spec.ts b/packages/dap/src/hpkeConfig.spec.ts index e8fa3c8c9..f12a746e0 100644 --- a/packages/dap/src/hpkeConfig.spec.ts +++ b/packages/dap/src/hpkeConfig.spec.ts @@ -252,7 +252,6 @@ describe("DAP HpkeConfig", () => { const kem = new DhkemP256HkdfSha256(); const { publicKey, privateKey } = await kem.generateKeyPair(); const key = await kem.serializePublicKey(publicKey); - console.log(Buffer.from(key).toString("ascii")); const config = new HpkeConfig( 100, From cedb74430a7c98b8d11c558752dde2caf3ee8cbc Mon Sep 17 00:00:00 2001 From: David Cook Date: Fri, 15 Sep 2023 15:24:10 -0500 Subject: [PATCH 2/2] Prohibit use of the console object --- .eslintrc.json | 3 ++- packages/interop-test-client/src/index.ts | 3 +++ scripts/benchmarks.ts | 2 ++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.eslintrc.json b/.eslintrc.json index f951591df..6214413d1 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -28,6 +28,7 @@ { "allowEmptyCatch": true } - ] + ], + "no-console": "error" } } diff --git a/packages/interop-test-client/src/index.ts b/packages/interop-test-client/src/index.ts index c30ee7a94..1ff90b3bf 100644 --- a/packages/interop-test-client/src/index.ts +++ b/packages/interop-test-client/src/index.ts @@ -1,4 +1,7 @@ // This script implements the client role of draft-dcook-ppm-dap-interop-test-design-02. + +/* eslint no-console: "off" */ + import type { Request, Response } from "express"; import express from "express"; import type { ReportOptions } from "@divviup/dap"; diff --git a/scripts/benchmarks.ts b/scripts/benchmarks.ts index b3ba1ed5a..eaa9e790f 100644 --- a/scripts/benchmarks.ts +++ b/scripts/benchmarks.ts @@ -1,3 +1,5 @@ +/* eslint no-console: "off" */ + import Benchmark from "benchmark"; import { Task, KnownVdafSpec, VdafMeasurement } from "dap/client"; import { TaskId } from "dap/taskId";