Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider aborting aggregation jobs entirely on certain errors from helper #235

Closed
branlwyd opened this issue Jun 13, 2022 · 1 comment · Fixed by #2502
Closed

Consider aborting aggregation jobs entirely on certain errors from helper #235

branlwyd opened this issue Jun 13, 2022 · 1 comment · Fixed by #2502

Comments

@branlwyd
Copy link
Member

When in the leader position, the aggregation job driver will currently retry (until normal too-many-retries logic causes us to stop) on any HTTP failure. Certain HTTP error codes and/or DAP error codes should probably cause us to abandon the aggregation job immediately. We may also want to give up if the helper responds with an unknown/unexpected content type.

@tgeoghegan
Copy link
Contributor

See also #1180 which has a lot of discussion around avoiding scheduling aggregation jobs that can't succeed. We need to articulate state machines for reports, aggregation jobs, collections and aggregate shares, see where they intersect and then implement that coherently, which might also feed back into DAP itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants