Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging release #228

Closed
gaetanww opened this issue Jan 7, 2020 · 5 comments
Closed

Tagging release #228

gaetanww opened this issue Jan 7, 2020 · 5 comments

Comments

@gaetanww
Copy link

gaetanww commented Jan 7, 2020

Would it be possible to tag releases with git tag? It would make exploring the repos easier :) It would also make pulling the repo with git and specifying a version a lot easier.

@gaetanww
Copy link
Author

gaetanww commented Jan 7, 2020

For a bit of context, I had to use git for pulling the repository to be able to use dbus-crossroads.

@diwic
Copy link
Owner

diwic commented Jan 8, 2020

It would be possible, given I come up with a good naming scheme (the repo has several crates, with separate versions).

As for dbus-crossroads, it's still very much in development but if you try it out and have some comments/suggestions it would be appreciated!

@gaetanww
Copy link
Author

gaetanww commented Jan 8, 2020

I didn't think it through, tagging versions is not straightforward at all with different crates in the same repo. I'll give it a think.

To use dbus-crossroads at the moment we have two solutions, either pulling out the project and refering it by path or pulling it with
dbus-crossroad = {git="https://github.com/diwic/dbus-rs.git" rev="<commit>"}. It took me a bit of time to figure that out (I'm not very quick :) ), so it could be useful to have it written somewhere in a README; especially since the server example in dbus-tokio works only with dbus-crossroads.

@gaetanww
Copy link
Author

gaetanww commented Jan 9, 2020

There's been a suggestion to tag with packagename-VERSION.
Do you think that would work?

@diwic
Copy link
Owner

diwic commented Jan 10, 2020

Okay, I've now done this for the last release of dbus and dbus-tokio at least. dbus-crossroads has no release yet.

@diwic diwic closed this as completed Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants