Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies with /Lslash.v slash contour #97

Closed
martelahaie opened this issue Oct 11, 2023 · 4 comments · Fixed by #98
Closed

Inconsistencies with /Lslash.v slash contour #97

martelahaie opened this issue Oct 11, 2023 · 4 comments · Fixed by #98

Comments

@martelahaie
Copy link
Collaborator

Hello @djrrb ! Another contour question: the position of the slash in Lslash.v seems to be different across all the 2-build/Bungee_Basic files, most notably in the 'inline' and 'shade' styles (see old build fonts column).
Currently in the new build script, the slash gets the same position everywhere (see new build fonts column).

Would it be okay to keep the new build like that or would you prefer the old positions of the slash?
Screenshot 2023-10-11 at 07 52 11

@djrrb
Copy link
Owner

djrrb commented Oct 11, 2023

Hi @martelahaie thanks for catching this!

I don’t have strong feelings on this, except to say that I think it’s worth fudging the shade so that the interior space is completely filled in, like in Lslash and we don’t get that skinny white shape. How do you feel about that?

@martelahaie
Copy link
Collaborator Author

Yes I also think that it's worth avoiding the skinny white shape here.
Then this will be another exception for the build script @justvanrossum.

@justvanrossum
Copy link
Collaborator

Hm this exception may be of a different kind than the other ones for Basic Shade, as it would be relevant for layering, too.

Do you see a way to tweak all 1-build layers Lslash.v so we don't have to make an exception? Even if that means that Lslash.v will be ever so slightly different in all versions compared to the released fonts.

@martelahaie
Copy link
Collaborator Author

Screenshot 2023-10-12 at 11 24 15

The old layer fonts don't follow the Lslash exception, but they probably should be the same.

Screenshot 2023-10-12 at 11 20 16

The two easiest adjustments would be to either move the slash (like the earlier exceptions) or elongate it.
I feel like elongating would be the least noticeable tweak, while still staying close to the non-vertical Lslash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants