Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicalReflectivityModel: missing parameters #58

Open
dkriegner opened this issue Sep 3, 2018 · 1 comment
Open

DynamicalReflectivityModel: missing parameters #58

dkriegner opened this issue Sep 3, 2018 · 1 comment

Comments

@dkriegner
Copy link
Owner

The DynamicalReflectivityModel does not use the resolution_width, sample_width, and beam_width parameters which SpecularReflectivity is using.

Does it make sense to add this functionality or do these parameters not make sense here?

My feeling is that since the two models calculate almost the same thing it that the parameters should be added. I guess that resolution_width is in particular easy since its just a convolution of the result where the respective function is already available in Model.convolute_resolution(x, y)

The other two might be more complicated since a consistent handling should be found for transmitivity and reflectivity.

@dkriegner
Copy link
Owner Author

@nlaanait : I would be very much interested in your opinion on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant