Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting of a "reference frame" in Experiment classes #98

Open
dkriegner opened this issue May 8, 2020 · 2 comments
Open

allow setting of a "reference frame" in Experiment classes #98

dkriegner opened this issue May 8, 2020 · 2 comments

Comments

@dkriegner
Copy link
Owner

Currently Experiment.Ang2Q (by default) converts the angular goniometer positions to a Q-coordinate frame fixed to the innermost goniometer circle, but using the laboratory coordinate system.

Ang2HKL (with appropriate parameters) can directly convert the angular positions to HKL values.

There is a third, currently somehow hidden intermediate step: a coordinate system fixed to the surface orientation of the crystal. By introducing a new parameter: "reference_frame" to Ang2Q a user could select the level of conversion he wishes to get.

@dkriegner
Copy link
Owner Author

Its also important to note that for Experiment.Ang2Q the two parameters of its constructor idir and ndir are not needed. This confuses many people which only use Ang2Q. When using the reference_frame='laboratory' then these two parameters can be omitted. Also the code should be more flexible and allow the user to specify a U or UB matrix instead of these two directions which are used automatically in Ang2Q or Ang2HKL when the reference_frame='sample' or reference_frame='crystal' are used.

@dkriegner
Copy link
Owner Author

One could also think of removing Ang2HKL and incorporate all functionality in Ang2Q. In fact Ang2HKL already now is only a wrapper around Ang2Q. This would make all use a bit simpler and also avoid the dettype parameter of Ang2HKL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant