-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single-column tables rendered incorrectly in README.md #546
Comments
we might want to consider using https://github.com/AuburnSounds/commonmark-d instead of the vibe built-in markdown capabilities (and maybe even deprecate/separate them from vibe) |
Ooh, would that mean that HTML tags would get rendered properly, too? |
the security aspect is something we would need to test for, since we don't want to accept any script tags or any kind of script injection |
Wow… why does that markdown standard allow you to use <script>!? HTML in markdown is usually just meant to be for advanced formatting (images, spoilers, etc.) |
well since the markdown converter might just pipe HTML tags as-is to the output. I don't see any allow-list of tags in that parser, so it might not be in the scope of it. |
Well the spec it follows says it should output “raw, unescaped HTML”, so I’m thinking the parser does that to be compliant. |
GitHub's markdown allows for single-column tables.
Written as:
However on the DUB registry in the Info section of a package, they turn into this soup:
| My Header | |-----------| | Item A | | Item B | | Item C |
You can see this happen with a few BindBC packages on the registry.
It's a small thing, but it makes the structure of a document look much nicer when they're rendered properly. They're even used in the DIP template.
The text was updated successfully, but these errors were encountered: