Don't wastefully execute everything via a shell #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 15 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5284832 bin/dub
-rough build time=77s
+executable size=5280736 bin/dub
+rough build time=76sFull build output |
WebFreak001
approved these changes
Jul 20, 2023
|
can you rebase to get the CI fixes in? |
We should only ever use the shell if we want to use the shell's features, such as pipes, non-trivial redirection, or shell language features (branches/loops/etc.). Otherwise, executing a program via the shell is pointless and wasteful.
CyberShadow
force-pushed
the
pull-20230720-123924
branch
from
20c5e39 to
0eeed18
Compare
|
Sure, done. |
Failure mode is different as we're no longer asking the shell to run the dummy program, we're doing it ourselves.
WebFreak001
reviewed
Jul 20, 2023
| @@ -61,7 +61,7 @@ fi | |||
| rm ../etc/dub/settings.json | |||
| echo "Empty file named ldc2." > ../bin/ldc2 | |||
|
|
|||
| if ! { ${DUB} describe --single issue103-single-file-package.d 2>&1 || true; } | grep -cF "Failed to invoke the compiler $(dirname $CURR_DIR)/bin/ldc2 to determine the build platform"; then | |||
| if ! { ${DUB} describe --single issue103-single-file-package.d 2>&1 || true; } | grep -cF "Failed to execute '$(dirname $CURR_DIR)/bin/ldc2'"; then | |||
There was a problem hiding this comment.
uh do you know why this failed? / needed to be changed
There was a problem hiding this comment.
Yes? I explained it in the commit message.
|
CyberShadow/DAutoTest stuck? |
|
It's running right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only ever use the shell if we want to use the shell's features, such as pipes, non-trivial redirection, or shell language features (branches/loops/etc.). Otherwise, executing a program via the shell is pointless and wasteful.