Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] FeatureFetcher throws exception if input_nodes does not contain target feature #7385

Closed
Rhett-Ying opened this issue May 9, 2024 · 2 comments · Fixed by #7386

Comments

@Rhett-Ying
Copy link
Collaborator

🐛 Bug

for type_name, feature_names in self.node_feature_keys.items():
nodes = input_nodes[type_name]

If input_nodes does not contain any keys(node/edge types) that are listed in node/edge_feature_key, exception is thrown. Should we skip for such case?

Expected behavior

Skip non-existent feature keys.

Environment

  • DGL Version (e.g., 1.0): master
  • Backend Library & Version (e.g., PyTorch 0.4.1, MXNet/Gluon 1.3):
  • OS (e.g., Linux):
  • How you installed DGL (conda, pip, source):
  • Build command you used (if compiling from source):
  • Python version:
  • CUDA/cuDNN version (if applicable):
  • GPU models and configuration (e.g. V100):
  • Any other relevant information:

Additional context

@mfbalin
Copy link
Collaborator

mfbalin commented May 9, 2024

Should we fix this before DGL 2.2 release as well? Seems like a big problem for the users.

@mfbalin
Copy link
Collaborator

mfbalin commented May 9, 2024

Isn't the fix simple adding a single if expression to check if input_nodes contains the key or not? If it doesn't, we can simply skip.

@Rhett-Ying Rhett-Ying linked a pull request May 9, 2024 that will close this issue
8 tasks
@github-project-automation github-project-automation bot moved this from 🏠 Backlog to ✅ Done in DGL Project Tracker May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants