From 84e395d91e9b150f261e6a1a677968843cd67e99 Mon Sep 17 00:00:00 2001 From: Jiaming Yuan Date: Wed, 5 Feb 2020 10:47:39 +0800 Subject: [PATCH] Fix CMake build on Windows with setuptools. (#5280) --- python-package/setup.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/python-package/setup.py b/python-package/setup.py index bbe1fce7759d..e1433af055be 100644 --- a/python-package/setup.py +++ b/python-package/setup.py @@ -95,6 +95,7 @@ class BuildExt(build_ext.build_ext): def build(self, src_dir, build_dir, generator, build_tool=None, use_omp=1): '''Build the core library with CMake.''' cmake_cmd = ['cmake', src_dir, generator] + for k, v in USER_OPTIONS.items(): arg = k.replace('-', '_').upper() value = str(v[2]) @@ -102,15 +103,15 @@ def build(self, src_dir, build_dir, generator, build_tool=None, use_omp=1): if k == 'USE_OPENMP' and use_omp == 0: continue - if system() == 'Windows': - cmake_cmd.append('--build') - subprocess.check_call(cmake_cmd, cwd=build_dir) if system() != 'Windows': nproc = os.cpu_count() subprocess.check_call([build_tool, '-j' + str(nproc)], cwd=build_dir) + else: + subprocess.check_call(['cmake', '--build', '.', + '--config', 'Release'], cwd=build_dir) def build_cmake_extension(self): '''Configure and build using CMake'''