Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in predicting on ellpack. #5351

Closed
trivialfis opened this issue Feb 23, 2020 · 1 comment · Fixed by #5504
Closed

Issues in predicting on ellpack. #5351

trivialfis opened this issue Feb 23, 2020 · 1 comment · Fixed by #5504

Comments

@trivialfis
Copy link
Member

trivialfis commented Feb 23, 2020

We implemented predicting on ellpack for reducing memory usage. But after some more testing, I found the implementation is not thoroughly considered. Here are a few more cases we need to put more thoughts on:

  • What if the user change tree method but use the same DMatrix?
  • What if the user train for another round but at the second round they put the training DMatrix as a validation DMatrix?

@RAMitchell

@trivialfis
Copy link
Member Author

The proper solution should be waiting for the new DMatrix interface, so that we only use ellpack prediction when there's no SparsePage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant