-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inplace Predict Java API (xgboost4j) #5951
Comments
Would you like to open a PR for it? Inplace prediction means XGBoost has to digest external data directly. I'm not familiar with the ecosystem of Java so I don't know what data types to support. |
Also after #5853 normal predict function should also be thread safe in xgboost native code. |
Good to know about #5853, but looks like it might take a while before we see it in release, and inplace_predict already does the job. Do you think it will be faster to add the Java wrapper to the inplace, than #5853 waiting for to make it release?
I will go over the required changes - although I am not sure on where the gotchas can potentially be. |
It's a blocking PR for the next release and we are now squashing the next release, so I would say pretty soon.
I can help with issues in C++. @CodingCat expressed interest in inplace prediction before. So maybe @CodingCat can provide some suggestions on related topics around JVM bindings. |
Hi guys, I'm working an online XGBoost prediction service, and want to use Java Multi thread for better performance. As C++ code has resolved thread safe feature, simply removing "synchronize" key word in Java "predict" method, could enable multi-thread prediction in Java Environment? |
The C API is thread safe now. You need to check whether JAVA layer has additional states. |
Java layer doesn't seem to maintain any state that get's updated on the Who's the maintainer / reviewer for the Java package? |
Any update on this issue? |
Need this feature +1 |
Hello.
I see that in the changelog for 1.1.0, a new API was added for thread safe prediction (
inplace_predict
). The currentpredict
method exposed through xgboost4j is not thread safe, and hence marked assynchronized
in the method.Given that the
inplace_predict
can now do threadsafe prediction, what are the plans of adding this to the Java API? We use this library in a multithreaded Java application, and this can help boost performance.Thanks,
Viswanath.
The text was updated successfully, but these errors were encountered: