Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Build and upload xgboost4j.dll in GitHub Actions #6748

Closed
hcho3 opened this issue Mar 11, 2021 · 2 comments · Fixed by #6781
Closed

[CI] Build and upload xgboost4j.dll in GitHub Actions #6748

hcho3 opened this issue Mar 11, 2021 · 2 comments · Fixed by #6781

Comments

@hcho3
Copy link
Collaborator

hcho3 commented Mar 11, 2021

Following up with #6630 (comment). Currently, we already run our CI on GitHub Actions which builds and tests XGBoost4J for the Windows platform. The byproduct xgboost4j.dll should be uploaded to a S3 bucket, so that later we can include it in the official Maven JAR release.

cc @Craigacp

@Craigacp
Copy link
Contributor

I did check the Windows build over the weekend, and adding the jar is sufficient to make the single node tests pass. I'm not sure if it's worth making xgboost4j-spark check it's platform and intentionally fail if it's Windows, as the tests do not pass there.

@bluelu
Copy link

bluelu commented Mar 15, 2021

I can also confirm that adding the windows dll to the jar is sufficient. Would be great if the windows dll could be finally integrated by default. Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants