Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.4 Patch Release. #8803

Closed
7 tasks done
trivialfis opened this issue Feb 14, 2023 · 11 comments
Closed
7 tasks done

1.7.4 Patch Release. #8803

trivialfis opened this issue Feb 14, 2023 · 11 comments

Comments

@trivialfis
Copy link
Member Author

R winbuilder result. It's failing on i386 but otherwise looks good.

Your package xgboost_1.7.4.1.tar.gz has been built (if working) and checked for Windows.
Please check the log files and (if working) the binary package at:
https://win-builder.r-project.org/GyaSK35w21NB
The files will be removed after roughly 72 hours.
Installation time in seconds: 703
Check time in seconds: 432
Status: OK
R version 4.2.2 (2022-10-31 ucrt)
Your package xgboost_1.7.4.1.tar.gz has been built (if working) and checked for Windows.
Please check the log files and (if working) the binary package at:
https://win-builder.r-project.org/TmDkKJPbkQ9G
The files will be removed after roughly 72 hours.
Installation time in seconds: 1412
Check time in seconds: 557
Status: 2 ERRORs, 1 WARNING, 1 NOTE
R version 4.1.3 (2022-03-10)

@trivialfis
Copy link
Member Author

Uploaded all python packages, and submitted CRAN package.

@trivialfis
Copy link
Member Author

trivialfis commented Feb 16, 2023

Failed CRAN pre-test:

* checking C++ specification ... NOTE
  Specified C++14: please drop specification unless essential

@hcho3
Copy link
Collaborator

hcho3 commented Feb 25, 2023

Let me upload the JVM packages

@trivialfis
Copy link
Member Author

@hcho3 If you haven't, please don't upload anything yet.

@hcho3
Copy link
Collaborator

hcho3 commented Feb 26, 2023

@trivialfis Is there any more modifications to make?

@trivialfis
Copy link
Member Author

We might need a fix for #8824 , @RAMitchell might be able to share some insights when he's available.

I'm looking into #8816 , which is not reproducible on my machines (tried two different devices and docker). Based on the log from this debug PR, the thread local cache might be problematic even though I don't have any clue about it. The regression test is accessing a DMatrix constructed from a classification test ...

@trivialfis
Copy link
Member Author

trivialfis commented Feb 27, 2023

Let's skip #8816 for now. It's caused by scala using a gc thread for booster destruction, resulting in different threads for construction and destruction.

@marcphilipp
Copy link
Contributor

Any updates on getting the JVM packages to Maven Central?

@trivialfis
Copy link
Member Author

@hcho3 Please continue the 1.7.4 release. I will wrap up all needed changes for 2.0 as soon as possible. The 1.7.4 release branch is quite difficult to work with now with the CI upgraded on the master branch.

@hcho3
Copy link
Collaborator

hcho3 commented Mar 8, 2023

I went ahead and uploaded 1.7.3 to Maven Central. https://repo1.maven.org/maven2/ml/dmlc/xgboost4j_2.12/1.7.4/

@hcho3 hcho3 closed this as completed Mar 8, 2023
@trivialfis trivialfis unpinned this issue Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants