Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidental SparsePage copies #3583

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Remove accidental SparsePage copies #3583

merged 1 commit into from
Aug 13, 2018

Conversation

RAMitchell
Copy link
Member

@hcho3 this heavily impacts performance of the linear models so it should go in 0.8 if possible.

@codecov-io
Copy link

codecov-io commented Aug 13, 2018

Codecov Report

Merging #3583 into master will increase coverage by 0.2%.
The diff coverage is 34.78%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #3583     +/-   ##
===========================================
+ Coverage     47.85%   48.05%   +0.2%     
  Complexity      188      188             
===========================================
  Files           169      169             
  Lines         13341    13331     -10     
  Branches        457      457             
===========================================
+ Hits           6384     6406     +22     
+ Misses         6732     6700     -32     
  Partials        225      225
Impacted Files Coverage Δ Complexity Δ
src/tree/updater_histmaker.cc 2.82% <0%> (ø) 0 <0> (ø) ⬇️
src/tree/updater_refresh.cc 5.88% <0%> (ø) 0 <0> (ø) ⬇️
src/gbm/gblinear.cc 13.87% <0%> (+0.15%) 0 <0> (ø) ⬇️
src/tree/updater_skmaker.cc 2.15% <0%> (ø) 0 <0> (ø) ⬇️
src/tree/updater_colmaker.cc 1.51% <0%> (ø) 0 <0> (ø) ⬇️
src/tree/updater_basemaker-inl.h 0% <0%> (ø) 0 <0> (ø) ⬇️
src/gbm/gbtree.cc 18.57% <0%> (ø) 0 <0> (ø) ⬇️
src/data/simple_dmatrix.cc 100% <100%> (ø) 0 <0> (ø) ⬇️
src/predictor/cpu_predictor.cc 65.06% <100%> (-0.31%) 0 <0> (ø)
src/data/sparse_page_dmatrix.cc 92.3% <100%> (ø) 0 <0> (ø) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b607fb...fe20485. Read the comment docs.

@hcho3
Copy link
Collaborator

hcho3 commented Aug 13, 2018

Interesting. I wonder if this would fix #3579.

@hcho3 hcho3 merged commit 645996b into dmlc:master Aug 13, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 11, 2018
@RAMitchell RAMitchell deleted the linear branch December 6, 2018 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants