Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft of 1.5 release note. [skip ci] #7271

Merged
merged 11 commits into from
Oct 21, 2021
Merged

Draft of 1.5 release note. [skip ci] #7271

merged 11 commits into from
Oct 21, 2021

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Sep 28, 2021 •
edited
Loading

@trivialfis trivialfis mentioned this pull request Sep 28, 2021
Closed
8 tasks
@trivialfis trivialfis changed the base branch from master to release_1.5.0 September 30, 2021 12:53
hcho3
hcho3 requested changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace all double backticks with single backticks. Code formatting in Markdown uses single backticks.

Also, can we add an Acknowledgment section? I can help with this.

NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@trivialfis
Copy link
Member Author

Ah, my poor writing.

trivialfis and others added 4 commits October 7, 2021 19:46
@trivialfis @hcho3
Apply suggestions from code review [skip ci]
50978ad 
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
@trivialfis @hcho3
Apply suggestions from code review [skip ci]
67a6b41 
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
@trivialfis
Fix quotes. [skip ci]
0afebfc
@trivialfis
Finishes todo items [skip ci]
613e6f3
@trivialfis
Copy link
Member Author

Please replace all double backticks with single backticks.

Fixed, thanks for noticing.

@trivialfis
Copy link
Member Author

Also, can we add an Acknowledgment section? I can help with this.

Please help with this. Somehow I hit the rate limit of the REST API used by the query_contributors.py script.

@trivialfis
Copy link
Member Author

Need to add notes about few more backported fixes.

trivialfis
trivialfis commented Oct 12, 2021
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@trivialfis trivialfis changed the base branch from release_1.5.0 to master October 13, 2021 12:43
@trivialfis trivialfis merged commit 7593fa9 into dmlc:master Oct 21, 2021
@trivialfis trivialfis deleted the 1.5-news branch October 21, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 requested changes

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trivialfis @hcho3 @RAMitchell