Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up code that uses Emulator/getDefault returned dictionary #5104

Open
ddaina opened this issue Nov 3, 2021 · 3 comments
Open

clean up code that uses Emulator/getDefault returned dictionary #5104

ddaina opened this issue Nov 3, 2021 · 3 comments
Assignees
Labels

Comments

@ddaina
Copy link
Contributor

ddaina commented Nov 3, 2021

find and remove all the places where ufc key from Emulator/getDefault returned dictionary is used. currently it returns dummy value: https://github.com/dmwm/CRABClient/blob/master/src/python/CRABClient/Emulator.py#L29

@ddaina ddaina added the CleanUp label Nov 3, 2021
@belforte belforte self-assigned this Nov 3, 2021
@belforte
Copy link
Member

I think this was done in #5115
Shall we remove the ufc key from Emulator.py and verify that nothing is broken ?
I never touched this becasue I never understood how this Emulator is working, but I suspect that we could simply get rid of it and directly instantiate CRABRest where needed. I do not see much use case for using a complicated way to insert some different REST interface to test.

@ddaina
Copy link
Contributor Author

ddaina commented Nov 23, 2021

I think this was done in #5115

I think you are right

Shall we remove the ufc key from Emulator.py and verify that nothing is broken ?

I will test it report results here, unless you are already doing it

@belforte
Copy link
Member

no. I was not doing it. Please test, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants