Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

compose-cli: fix PAT detection for PAT suggestion #2259

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

landism
Copy link
Contributor

@landism landism commented Jul 25, 2023

What I did

Problem

When logging in with a PAT, docker login tells me... I should be using a PAT:

docker login
Authenticating with existing credentials...
Login Succeeded

Logging in with your password grants your terminal complete access to your account.
For better security, log in with a limited-privilege personal access token. Learn more at https://docs.docker.com/go/access-tokens/

compose-cli is looking for the prefix dckrp_ but hub currently issues pats with the prefix dckr_pat_.

Solution

Also check for the prefix dckr_pat_. (maybe we could just exclusively check for this prefix? I have not looked into the history of dckrp_)

Related issue

(not mandatory) A picture of a cute animal, if possible in relation with what you did

@github-actions github-actions bot added the cli cli label Jul 25, 2023
@landism
Copy link
Contributor Author

landism commented Jul 25, 2023

@milas apparently I don't have access to add reviewers in this repo

@milas milas self-requested a review July 26, 2023 12:40
@milas milas merged commit 118cd6d into docker-archive:main Jul 26, 2023
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cli cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants