Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache envvars not being loaded #481

Closed
evertramos opened this issue Aug 19, 2017 · 1 comment
Closed

Apache envvars not being loaded #481

evertramos opened this issue Aug 19, 2017 · 1 comment

Comments

@evertramos
Copy link

evertramos commented Aug 19, 2017

Hello there!

It seems for some reason that this merge did not correct the envvar for php-7.1.8-apache as of https://github.com/docker-library/php/pull/251/files

Same point of #97

@yosifkit
Copy link
Member

7.1-rc1 was added in #296 and has the same changes as #251.

# Note: we don't just use "apache2ctl" here because it itself is just a shell-script wrapper around apache2 which provides extra functionality like "apache2ctl start" for launching apache2 in the background.
# (also, when run as "apache2ctl <apache args>", it does not use "exec", which leaves an undesirable resident shell process)
: "${APACHE_CONFDIR:=/etc/apache2}"
: "${APACHE_ENVVARS:=$APACHE_CONFDIR/envvars}"
if test -f "$APACHE_ENVVARS"; then
. "$APACHE_ENVVARS"
fi
# Apache gets grumpy about PID files pre-existing
: "${APACHE_RUN_DIR:=/var/run/apache2}"
: "${APACHE_PID_FILE:=$APACHE_RUN_DIR/apache2.pid}"
rm -f "$APACHE_PID_FILE"

@tianon tianon closed this as completed Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants