Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use compose service methods when exist instead of directly service.dockerCli #10175

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

glours
Copy link
Contributor

@glours glours commented Jan 13, 2023

Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com

What I did
use internal functions of composeService struct when exist instead of accessing via the composeService.dockerCli attribute

Related issue
see discussions in #10173

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

…ckerCli

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours self-assigned this Jan 13, 2023
@glours glours requested a review from ndeloof January 13, 2023 18:11
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 74.26% // Head: 73.89% // Decreases project coverage by -0.36% ⚠️

Coverage data is based on head (eca0e1b) compared to base (8c07fa4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10175      +/-   ##
==========================================
- Coverage   74.26%   73.89%   -0.37%     
==========================================
  Files           2        2              
  Lines         272      272              
==========================================
- Hits          202      201       -1     
- Misses         59       60       +1     
  Partials       11       11              
Impacted Files Coverage Δ
pkg/e2e/framework.go 72.15% <0.00%> (-0.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof ndeloof merged commit 5a2b7b8 into docker:v2 Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants