add docker events --format

[AkihiroSuda]

- What I did
Add docker events --format.

Note that -f is the short form of the existing --filter.
(similar to docker ps)

- How I did it
Please refer to the code

- How to verify it
Example: JSON Lines (aka NDJSON, LDJSON, JSON stream, ...)

$ docker events --format="{{json .}}"
{"status":"create","id":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","from":"alpine","Type":"container","Action":"create","Actor":{"ID":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","Attributes":{"image":"alpine","name":"goofy_yonath"}},"time":1472807143,"timeNano":1472807143011844368}
{"status":"attach","id":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","from":"alpine","Type":"container","Action":"attach","Actor":{"ID":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","Attributes":{"image":"alpine","name":"goofy_yonath"}},"time":1472807143,"timeNano":1472807143012990299}
{"Type":"network","Action":"connect","Actor":{"ID":"c8b01845e3aa17dc3f9026125c44cf0075de8672a086c04ecfa02c6d8b359afa","Attributes":{"container":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","name":"bridge","type":"bridge"}},"time":1472807143,"timeNano":1472807143033449708}
{"status":"start","id":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","from":"alpine","Type":"container","Action":"start","Actor":{"ID":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","Attributes":{"image":"alpine","name":"goofy_yonath"}},"time":1472807143,"timeNano":1472807143208051400}
{"status":"resize","id":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","from":"alpine","Type":"container","Action":"resize","Actor":{"ID":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","Attributes":{"height":"46","image":"alpine","name":"goofy_yonath","width":"174"}},"time":1472807143,"timeNano":1472807143209296139}
{"status":"die","id":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","from":"alpine","Type":"container","Action":"die","Actor":{"ID":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","Attributes":{"exitCode":"0","image":"alpine","name":"goofy_yonath"}},"time":1472807143,"timeNano":1472807143241584111}
{"Type":"network","Action":"disconnect","Actor":{"ID":"c8b01845e3aa17dc3f9026125c44cf0075de8672a086c04ecfa02c6d8b359afa","Attributes":{"container":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","name":"bridge","type":"bridge"}},"time":1472807143,"timeNano":1472807143384316935}
{"status":"destroy","id":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","from":"alpine","Type":"container","Action":"destroy","Actor":{"ID":"7129b55274d19b62cbae90561b455403a3784364d4187c42cf1d533dd665b112","Attributes":{"image":"alpine","name":"goofy_yonath"}},"time":1472807143,"timeNano":1472807143421794702}

automated test:

$ DOCKER_INCREMENTAL_BINARY=1 TESTFLAGS='-check.f DockerSuite.TestEvents' make test-integration-cli 

- Description for the changelog
add docker events --format

- A picture of a cute animal (not mandatory but encouraged)
https://commons.wikimedia.org/wiki/Pygoscelis_adeliae

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

[vieux]

interesting, LGTM

[vdemeester]

Design LGTM too
/cc @icecrime @cpuguy83

[cpuguy83]

SGTM

[cpuguy83]

Moved to code-review

[cpuguy83]

And LGTM

[vdemeester]

A backtick is missing here 😅

[AkihiroSuda]

done

[vdemeester]

Code LGTM
/cc @dnephin

@AkihiroSuda on the documentation side, few small comments (misses) — we might want to also show an example with a field in addition the the json one 👼

[dnephin]

Formatting looks strange here. I think it should be:

return cli.StatusError{
    StatusCode: 64,
    Status: "Template parsing error: " + err.Error(),
}

and the error should be "Error parsing format: ", since the user is specfying a --format not --template.

[AkihiroSuda]

done

[dnephin]

LGTM

[AkihiroSuda]

rebased to upstream
@vieux @vdemeester @cpuguy83 @dnephin

[vdemeester]

Still code LGTM, moving to doc review and docs LGTM 🐸
/cc @thaJeztah @SvenDowideit

[thaJeztah]

Wonder if we should use an example that doesn't use "Type" in the template's condition (using --filter type=container is probably more useful to do that?)

[AkihiroSuda]

OK, updated PR

[thaJeztah]

docs LGTM