Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Action] Upgrade to buildx #122

Closed
chris-crone opened this issue Jul 8, 2020 · 2 comments
Closed

[GitHub Action] Upgrade to buildx #122

chris-crone opened this issue Jul 8, 2020 · 2 comments
Labels
community_new New idea raised by a community contributor

Comments

@chris-crone
Copy link
Member

Tell us about your request
The Docker GitHub Action currently uses the features provided by docker build. Faster builds are accessible by using BuildKit but this requires setting an environment variable which is not obvious to most users. Building multi arch images is currently not possible. This proposes moving the GitHub Action to use buildx which provides these features out of the box.

Which service(s) is this request for?
This is for the Docker GitHub Action which can be found here. Source code for the Action can be found here.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

  • Using BuildKit for faster builds
  • Building multiarch images

Are you currently working around the issue?
N/A

Additional context
More technical details can be found on the Docker GitHub Action's issue tracker.

@chris-crone chris-crone added the community_new New idea raised by a community contributor label Jul 8, 2020
@crazy-max
Copy link
Member

crazy-max commented Jul 8, 2020

See also docker/build-push-action#71

@christian-weiss
Copy link

I just want to show some love for this issue - i hope it motivates you to finish it soon.

For the very first release of the Github Action (docker build-based) the team had looked around for examples in the wild.

One example (not Github-based, but Dockerhub-based):
I would love to see this project building its buildx-based Dockerfile on Github with your Github Action instead of on Dockerhub: https://github.com/CBrosius/icinga2/blob/master/Dockerfile.arm32v7 / https://github.com/CBrosius/icinga2/blob/master/multi-arch-manifest.yaml

So your `buildx-based pimped Github Action is warm welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_new New idea raised by a community contributor
Projects
Status: Shipped! Enjoy!
Development

No branches or pull requests

4 participants