-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate duplicate published port in ServiceSpec #1495
validate duplicate published port in ServiceSpec #1495
Conversation
Signed-off-by: allencloud <allen.sun@daocloud.io>
Current coverage is 55.34% (diff: 100%)@@ master #1495 diff @@
==========================================
Files 82 82
Lines 12873 12873
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7118 7125 +7
+ Misses 4767 4765 -2
+ Partials 988 983 -5
|
ping @mrjana |
LGTM |
LGTM ping @cpuguy83 PTAL |
LGTM |
Hi, has anybody come across an issue when registering a service using udp & tcp on the same port? "Error response from daemon: rpc error: code = 3 desc = EndpointSpec: duplicate published ports provided" This has started happening with v1.12.2 and was fine with v1.12.1 I'm running the service with
|
@jamesdmorgan: Thank you for pointing this out. I opened #1632 to fix it. |
fixed #1494
Currently, swarmkit checks the whole
*port
to avoid duplication.This PR makes swarmkit to check the published port of
PortConfig
.Signed-off-by: allencloud allen.sun@daocloud.io