From 50c2434ab57b78d7a6a2a73c447b208a9e4f9d02 Mon Sep 17 00:00:00 2001 From: slengyel-lnx <34274270+slengyel-lnx@users.noreply.github.com> Date: Tue, 23 Oct 2018 09:58:24 +0300 Subject: [PATCH] fix: improve external script plugin (#632) --- lib/plugins/external-script.js | 2 +- lib/plugins/external-script.min.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/plugins/external-script.js b/lib/plugins/external-script.js index 9d0b332c8..785f23d30 100644 --- a/lib/plugins/external-script.js +++ b/lib/plugins/external-script.js @@ -10,7 +10,7 @@ function handleExternalScript() { var newScript = document.createElement('script'); Array.prototype.slice.call(script.attributes).forEach(function (attribute) { - newScript[attribute.name] = attribute.value; + newScript.setAttribute(attribute.name, attribute.value); }); script.parentNode.insertBefore(newScript, script); diff --git a/lib/plugins/external-script.min.js b/lib/plugins/external-script.min.js index 13423c47a..f6eb1ceae 100644 --- a/lib/plugins/external-script.min.js +++ b/lib/plugins/external-script.min.js @@ -1 +1 @@ -!function(){function o(){for(var o=Docsify.dom.getNode("#main"),e=Docsify.dom.findAll(o,"script"),n=e.length;n--;){var i=e[n];if(i&&i.src){var t=document.createElement("script");Array.prototype.slice.call(i.attributes).forEach(function(o){t[o.name]=o.value}),i.parentNode.insertBefore(t,i),i.parentNode.removeChild(i)}}}window.$docsify.plugins=[].concat(function(e){e.doneEach(o)},window.$docsify.plugins)}(); +!function(){function o(){for(var o=Docsify.dom.getNode("#main"),e=Docsify.dom.findAll(o,"script"),n=e.length;n--;){var i=e[n];if(i&&i.src){var t=document.createElement("script");Array.prototype.slice.call(i.attributes).forEach(function(o){t.setAttribute(o.name, o.value),i.parentNode.insertBefore(t,i),i.parentNode.removeChild(i)}}}window.$docsify.plugins=[].concat(function(e){e.doneEach(o)},window.$docsify.plugins)}();