Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search accents marks #1405

Closed
EloFran opened this issue Oct 20, 2020 · 8 comments · Fixed by #1434
Closed

search accents marks #1405

EloFran opened this issue Oct 20, 2020 · 8 comments · Fixed by #1434

Comments

@EloFran
Copy link

EloFran commented Oct 20, 2020

Feature request

It posible that search plugin ignore accents marks (tildes) ?

What problem does this feature solve?

id like that the words with accents to be the same with out accents.

What does the proposed API look like?

In the Spanish lenguage is important write accents, but in the search, the peoples does not usually add them.

How should this be implemented in your opinion?

adding some kind of routine that ignores accents in vowels: á é í ó ú
for example: artículo or articulo to be the same

Are you willing to work on this yourself?

yes

@sy-records
Copy link
Member

I test can search for content, what are you referring to?

image

@sy-records sy-records added question wait for information something is not clear, waiting for the author of the issue/pr labels Nov 3, 2020
@EloFran
Copy link
Author

EloFran commented Nov 4, 2020

yes its correct, but if you search without "accent" it should find it anyway. In Spanish a lot of peoples no using accents in their search.

image

@sy-records
Copy link
Member

sy-records commented Nov 5, 2020

Okay, I misread it, you need to ignore accent...

@StephaneG31
Copy link

StephaneG31 commented Nov 19, 2020

I have the same problem with French, often people avoid accent for searching

@sy-records sy-records added enhancement help wanted pr welcome and removed wait for information something is not clear, waiting for the author of the issue/pr question labels Nov 20, 2020
@EloFran
Copy link
Author

EloFran commented Nov 26, 2020

In Spanish there are words that have or do not have an accent depending on the context, but if you are looking for only the word it should appear in all its contexts. If we add that people in search engines do not use accents, they are usually ignored, because for example Google, you find it both with and without it.

@sy-records
Copy link
Member

@EloFran @StephaneG31 Hello, do you have any comments on the results of such a search? Do I need to show accents in the results?

image

image

@StephaneG31
Copy link

It's better to have accent in the result but if it's too complicated it's acceptable.

Moreover (but it's not the same problem, maybe I have to open an other issue) in the result pane, html is sometimes displayed (in the capture you can see the ' character displayed with ...9; in the expression "Let's".)

@sy-records
Copy link
Member

Yes, I know the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants