Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: font-size changing for code in headings #1456

Merged
merged 8 commits into from
Feb 5, 2021
Merged

fix: font-size changing for code in headings #1456

merged 8 commits into from
Feb 5, 2021

Conversation

Yash-Singh1
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of the default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel
Copy link

vercel bot commented Dec 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/a4onqhfnz
✅ Preview: https://docsify-preview-git-fork-yash-singh1-develop.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b61b11:

Sandbox Source
docsify-template Configuration

@Yash-Singh1
Copy link
Contributor Author

Before:
Screenshot from 2020-12-27 16-11-26
After:
Screenshot from 2020-12-27 16-11-39

@trusktr
Copy link
Member

trusktr commented Dec 28, 2020

Thanks @Yash-Singh1! This bugged me before too, and I put custom style on my site.

@docsifyjs/reviewers should this sort of change be saved for v5? It is an ideal change, but does have some chance (even if small) to break someone's v4 site.

@anikethsaha
Copy link
Member

I agree, it may break snapshot testing as far as I can think.
But I think its worth adding now as we really dont know how long it will take to land v5.
This looks more like a bug so I guess we can add this.

let me know if I am missing anything

@sy-records
Copy link
Member

I think it can be released from v4.12.0

@sy-records sy-records changed the title bug: Fix font-size changing for code in headings fix: Fix font-size changing for code in headings Feb 5, 2021
Copy link
Member

@jhildenbiddle jhildenbiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhildenbiddle jhildenbiddle merged commit c7f4c7c into docsifyjs:develop Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants