Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use legacy-compatible methods for IE11 #1495

Merged
merged 2 commits into from
Feb 7, 2021
Merged

Conversation

jhildenbiddle
Copy link
Member

Summary

Modern convenience methods like Array.prototype.find() and String.prototype.startsWith() are not compatible with legacy browsers like IE11. This PR replaces those methods with legacy-compatible approaches that accomplish the same thing.

What kind of change does this PR introduce? (check at least one)

  • Bugfix

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Feb 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/67c5ixoo8
✅ Preview: https://docsify-preview-git-fix-search-ie11.docsify-core.vercel.app

@jhildenbiddle jhildenbiddle requested a review from a team February 7, 2021 06:52
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 37b7166:

Sandbox Source
docsify-template Configuration

@sy-records sy-records mentioned this pull request Feb 7, 2021
3 tasks
Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants