ref #1803: fix cross-origin links in history router mode #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sspelled "crossorgin" link helper, and instead detect cross origin links and don't handle them as internal
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 292e788:
|
trusktr
added a commit
to lume/lume.github.io
that referenced
this pull request
Jan 22, 2023
sy-records
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the crossOriginLinks option is no longer needed, remove misspelled "crossorgin" link helper, and instead detect cross origin links and don't handle them as internal
Summary
External links are now navigable by default when
routerModeishistory, regardless of theexternalLinksTargetvalue.The
crossOriginLinksoption was added as a way to force external links to not be handled as internal.Instead, that feature has been removed, and now we use
isExternalto check for external links, and avoid handling them as internal.The value of an
<a>tag'stargetis no longer used as our external link check.What kind of change does this PR introduce?
Bugfix
Docs
For any code change,
Does this PR introduce a breaking change? (check one)
The
crossOriginLinksoption is now ignored. I don't think this is breaking. I think people want external links to work properly, so at worst some people will have listed all their links in that array, but now they don't have to.Thinking of tests to add...
Related issue, if any:
fixes #1803
Tested in the following browsers: