Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emoji in comment should not be processed #742

Closed
upupming opened this issue Jan 12, 2019 · 4 comments · Fixed by #1746
Closed

emoji in comment should not be processed #742

upupming opened this issue Jan 12, 2019 · 4 comments · Fixed by #1746
Labels
bug confirmed as a bug

Comments

@upupming
Copy link
Contributor

The following md:

So this: <!-- begin-inline-katex
\def\arraystretch{1.5}
   \begin{array}{c:c:c}
   a & b & c \\ \hline
   d & e & f \\
   \hdashline
   g & h & i
\end{array}
end-inline-katex-->

will be rendered as:

<p>So this: <!-- begin-inline-katex
\def\arraystretch{1.5}
   \begin{array}{c<img class="emoji" src="https://assets-cdn.github.com/images/icons/emoji/c.png" alt="c" />c}
   a & b & c \\ \hline
   d & e & f \\
   \hdashline
   g & h & i
\end{array}
end-inline-katex--></p>

It is expected to leave the content in comments unchanged.

@timaschew timaschew added the bug confirmed as a bug label Jan 29, 2019
@anikethsaha
Copy link
Member

anikethsaha commented Feb 14, 2020

Please use __colon__ instead of colon

So this: <!-- begin-inline-katex
\def\arraystretch{1.5}
   \begin{array}{c__colon__c__colon__c}
   a & b & c \\ \hline
   d & e & f \\
   \hdashline
   g & h & i
\end{array}
end-inline-katex-->

Hope it helps

@atuttle
Copy link

atuttle commented Oct 1, 2020

is this __colon__ behavior documented anywhere? Does it work outside of code blocks? I'm running into a similar problem inside of a markdown heading:

For example:

## foo:bar:baz

which should render as

foo:bar:baz

but the colons are being used to try and load an emoji named bar.

@sy-records
Copy link
Member

image
@atuttle I tested normal, what's wrong with you?

@atuttle
Copy link

atuttle commented Oct 2, 2020

@sy-records I'm not saying that it doesn't work, I'm saying that it's undocumented. If this is the proper way to avoid unintentional conversion to emoji, it should be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed as a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants