From 1c9ce150576d272b21c162c344b8b9bb1651ed2f Mon Sep 17 00:00:00 2001
From: John Hildenbiddle <john@hildenbiddle.com>
Date: Mon, 28 Jan 2019 22:58:05 -0800
Subject: [PATCH] Fix task list rendering (Fix #749)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Add “task-list” class to task list `<ul>` elms
- Add “task-list-item” class to task list `<li>` elms
- Hide list bullets on unordered task lists `<li>` elms
- Display list numbers on ordered task lists `<li>` elms
- Render accessible task list items by wrapping checkbox and text in `<label>` elm
---
 src/core/render/compiler.js   | 17 +++++++++++++++++
 src/themes/basic/_layout.styl |  3 +++
 2 files changed, 20 insertions(+)

diff --git a/src/core/render/compiler.js b/src/core/render/compiler.js
index b086b1476..91b954c02 100644
--- a/src/core/render/compiler.js
+++ b/src/core/render/compiler.js
@@ -302,6 +302,23 @@ export class Compiler {
 
       return `<img src="${url}"data-origin="${href}" alt="${text}"${attrs}>`
     }
+    origin.list = renderer.list = function (body, ordered, start) {
+      const isTaskList = /<li class="task-list-item">/.test(body.split('class="task-list"')[0])
+      const isStartReq = start && start > 1
+      const tag = ordered ? 'ol' : 'ul'
+      const tagAttrs = [
+        (isTaskList ? 'class="task-list"' : ''),
+        (isStartReq ? `start="${start}"` : '')
+      ].join(' ').trim()
+
+      return `<${tag} ${tagAttrs}>${body}</${tag}>`
+    }
+    origin.listitem = renderer.listitem = function (text) {
+      const isTaskItem = /^(<input.*type="checkbox"[^>]*>)/.test(text)
+      const html = isTaskItem ? `<li class="task-list-item"><label>${text}</label></li>` : `<li>${text}</li>`
+
+      return html
+    }
 
     renderer.origin = origin
 
diff --git a/src/themes/basic/_layout.styl b/src/themes/basic/_layout.styl
index f74d1ede8..4e00e33f0 100644
--- a/src/themes/basic/_layout.styl
+++ b/src/themes/basic/_layout.styl
@@ -383,6 +383,9 @@ body.sticky
   border-radius 2px
   padding 1rem
 
+.markdown-section ul.task-list > li
+  list-style-type none
+
 body.close
   .sidebar
     transform translateX(- $sidebar-width)