Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented BC break about migration generator #1000

Closed
VincentLanglet opened this issue Jun 17, 2020 · 4 comments
Closed

Undocumented BC break about migration generator #1000

VincentLanglet opened this issue Jun 17, 2020 · 4 comments

Comments

@VincentLanglet
Copy link
Contributor

BC Break Report

Summary

The migration generator does not replace the same variable between 2.x and 3.0.
It leads to a BC break non documented if you use custom template.

Previous behavior

final class Version<version>

was correctly replaced.

Current behavior

Now it's not. We have to write

final class <classname>
@greg0ire
Copy link
Member

greg0ire commented Jun 17, 2020

@tarlepp documented it with doctrine/DoctrineMigrationsBundle#334, but on the bundle repository. Wouldn't hurt to do it on both I guess.

@VincentLanglet
Copy link
Contributor Author

I think it can be enough on the bundle.

But I missed it because I looked at the default branch UPGRADE file: https://github.com/doctrine/DoctrineMigrationsBundle/blob/master/UPGRADE.md

@greg0ire
Copy link
Member

greg0ire commented Jun 17, 2020

Right, I will do an up-merge PR (and we should probably change the default branch too)

@VincentLanglet
Copy link
Contributor Author

Ok, I close this then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants