From 594f6fa95c0fe7b8224458a401831ef96fcdb892 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Sat, 28 Nov 2020 16:17:51 +0100 Subject: [PATCH] Run roave-bc-check on PRs only github.event.pull_request.base.sha is not defined when pushing a branch, which means that job will always be failing for pushes. --- .github/workflows/bc-check.yml | 19 +++++++++++++++++++ .github/workflows/continuous-integration.yml | 13 ------------- 2 files changed, 19 insertions(+), 13 deletions(-) create mode 100644 .github/workflows/bc-check.yml diff --git a/.github/workflows/bc-check.yml b/.github/workflows/bc-check.yml new file mode 100644 index 0000000000..0b510c7850 --- /dev/null +++ b/.github/workflows/bc-check.yml @@ -0,0 +1,19 @@ + +name: "Backward Compatibility Check" + +on: + pull_request: + +jobs: + roave_bc_check: + name: "Roave BC Check" + runs-on: "ubuntu-20.04" + steps: + - uses: "actions/checkout@v2" + with: + fetch-depth: 0 + + - name: "Roave BC Check" + uses: "docker://nyholm/roave-bc-check-ga" + with: + args: "--from=${{ github.event.pull_request.base.sha }}" diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 331b6c762b..529f81f6b8 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -8,19 +8,6 @@ on: - "*.x" jobs: - roave_bc_check: - name: "Roave BC Check" - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - with: - fetch-depth: 0 - - - name: Roave BC Check - uses: docker://nyholm/roave-bc-check-ga - with: - args: --from=${{ github.event.pull_request.base.sha }} - phpunit: name: "PHPUnit" runs-on: "ubuntu-20.04"