-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generics via static analysis #72
Comments
https://github.com/weirdan/doctrine-psalm-plugin was brought to my attention today. @weirdan would you be open to contributing the annotations to our libraries directly? We've added them to doctrine/collections, but I'd love to see these in all other projects as well. |
But of course! What do I need to do to make that happen?
For the record, PHPStan reads some |
A pull request to master is a great start. If you want we can discuss this tomorrow in the symfony-devs or doctrine Slack 👍 |
Unfortunately I won't have time for this before Sunday, so definitely not going to happen tomorrow. |
No worries at all. I'll be off for most of the next two weeks, so please take some time to enjoy the holidays. No need to rush anything here. |
I am also up for help if needed! Nice to see it get to other Doctrine projects as well. |
@weirdan @nschoellhorn working with you on annotations was great! Would love to do this again for all persistence libraries. Right @Ocramius? |
this has been implemented |
As was done in doctrine/collections, we should add support for generics using the
@psalm-template
annotations for generic classes like Repositories and Registries. We should also ensure that generics in PHPStan are supported as well.See doctrine/collections#177 for the reference implementation in collections.
The text was updated successfully, but these errors were encountered: